-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement conventional commit validation #418
Conversation
This PR is more about CI than documentation, please update the Proposed Changes section of the PR description. Thanks! |
I would have made it its own step and validate commits only once instead of validating in each platform. Are there benefits of doing it in each platform? |
@MatFillion that's what was done in a project shown in an example internally but I agree I would change it to run it once. |
You mean have a stage dedicated to this validation? |
I agree. It makes more sense to run it once |
Correct, in it's own stage would be the correct term, not step. |
This should be one ci commit. |
80dd8d0
to
daf117f
Compare
daf117f
to
eb222c7
Compare
eb222c7
to
773cffb
Compare
69a9d07
to
9ae00d9
Compare
f63e711
to
7c08a8d
Compare
88520cc
to
dd55ca9
Compare
GitHub Issue: #
Proposed Changes
Description
Impact on version
PR Checklist
Always applicable
No matter your changes, these checks always apply.
README.md
andTemplateConfig.md
if you made changes to templating.AzurePipelines.md
andAPP_README.md
if you made changes to pipelines.Diagnostics.md
if you made changes to diagnostic tools.Architecture.md
and its diagrams if you made architecture decisions or if you introduced new recipes.doc/
folder.Contextual
Based on your changes these checks may not apply.
Other information
Internal Issue (If applicable):