Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update refit package to address security advisory #419

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mahdichtioui
Copy link
Contributor

@mahdichtioui mahdichtioui commented Dec 2, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

Updating the Refit package version from 7.0.0 to 8.0.0 to address security advisory

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and TemplateConfig.md if you made changes to templating.
    • Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@lamonfly lamonfly self-requested a review December 3, 2024 13:59
@lamonfly
Copy link
Contributor

lamonfly commented Dec 3, 2024

This should be a major version change as it is a Fix!
Don't forget to go through the PR checklist. It should mention to bump the minor version and update the documentation.

@mahdichtioui mahdichtioui changed the title build: update refit package version fix!: update refit package to address security advisory Dec 3, 2024
@mahdichtioui mahdichtioui force-pushed the dev/mach/update-refit-version branch 2 times, most recently from 2d66d78 to 3cebe63 Compare December 4, 2024 09:26
@jeanplevesque
Copy link
Member

This should be a major version change as it is a Fix! Don't forget to go through the PR checklist. It should mention to bump the minor version and update the documentation.

@lamonfly @mahdichtioui Actually, this repository is not publishing any nuget package that others can install as a dependency. It's an application template so it's closer to an application. In this context, the definition for Major, Minor, and Patch aren't the same (as described in the PR template). In this particular case, you should use a Patch with a fix: conventional commit.

CHANGELOG.md Outdated Show resolved Hide resolved
@mahdichtioui mahdichtioui force-pushed the dev/mach/update-refit-version branch from 3cebe63 to e93331c Compare December 4, 2024 14:20
@mahdichtioui mahdichtioui changed the title fix!: update refit package to address security advisory fix: update refit package to address security advisory Dec 4, 2024
@jeanplevesque jeanplevesque requested a review from a team December 5, 2024 13:17
@jeanplevesque jeanplevesque merged commit c5ac45c into main Dec 5, 2024
14 checks passed
@jeanplevesque jeanplevesque deleted the dev/mach/update-refit-version branch December 5, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants