feat(311699): Refacto weatherEndpoints.cs

nventive · Dec 12, 2024 · 6bc4b03 · 6bc4b03
1 parent 3facfb0
commit 6bc4b03
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 33 deletions.
diff --git a/template/src/Placeholder.ApiService/Endpoints/WeatherEndpoints.cs b/template/src/Placeholder.ApiService/Endpoints/WeatherEndpoints.cs
@@ -7,36 +7,46 @@ public static class WeatherEndpoints
 {
     public static void MapWeatherEndpoints(this IEndpointRouteBuilder endpoints)
     {
-        endpoints.MapGet("/weathers", async (IWeatherService weatherService) =>
-        {
-            IEnumerable<Weather> weathers = await weatherService.GetWeathers();
-            return Results.Ok(weathers);
-        });
-
-        endpoints.MapGet("/weather/{weatherId}", async (long weatherId, IWeatherService weatherService) =>
-        {
-            Weather? weather = await weatherService.GetWeather(weatherId);
-
-            if (weather is null) return Results.NotFound();
-            return Results.Ok(weather);
-        });
-
-        endpoints.MapPost("/weather", async ([FromBody] Weather weather, IWeatherService weatherService) =>
-        {
-            Weather? weatherCreated = await weatherService.CreateWeather(weather);
-            return Results.Created($"/{weatherCreated?.Id}", weatherCreated);
-        });
-
-        endpoints.MapPut("/weather/{weatherId}", async (long weatherId, [FromBody] Weather weather, IWeatherService weatherService) =>
-        {
-            Weather? weatherUpdated = await weatherService.UpdateWeather(weatherId, weather);
-            return Results.Ok(weatherUpdated);
-        });
-
-        endpoints.MapDelete("/weather/{weatherId}", async (long weatherId, IWeatherService weatherService) =>
-        {
-            await weatherService.DeleteWeather(weatherId);
-            return Results.Ok();
-        });
+        endpoints.MapGet("/weathers", GetAllWeathers);
+        endpoints.MapGet("/weather/{weatherId}", GetWeatherById);
+        endpoints.MapPost("/weather", CreateWeather);
+        endpoints.MapPut("/weather/{weatherId}", UpdateWeather);
+        endpoints.MapDelete("/weather/{weatherId}", DeleteWeather);
+    }
+
+    private static async Task<IResult> GetAllWeathers(IWeatherService weatherService)
+    {
+        IEnumerable<Weather> weathers = await weatherService.GetWeathers();
+        return Results.Ok(weathers);
+    }
+
+    private static async Task<IResult> GetWeatherById(long weatherId, IWeatherService weatherService)
+    {
+        Weather? weather = await weatherService.GetWeather(weatherId);
+
+        if (weather is null) return Results.NotFound();
+        return Results.Ok(weather);
+    }
+
+    private static async Task<IResult> CreateWeather([FromBody] Weather weather, IWeatherService weatherService)
+    {
+        Weather? weatherCreated = await weatherService.CreateWeather(weather);
+
+        if (weatherCreated is null) return Results.NotFound();
+        return Results.Created($"/{weatherCreated?.Id}", weatherCreated);
+    }
+
+    private static async Task<IResult> UpdateWeather(long weatherId, [FromBody] Weather weather, IWeatherService weatherService)
+    {
+        Weather? weatherUpdated = await weatherService.UpdateWeather(weatherId, weather);
+
+        if (weatherUpdated is null) return Results.NotFound();
+        return Results.Ok(weatherUpdated);
+    }
+
+    private static async Task<IResult> DeleteWeather(long weatherId, IWeatherService weatherService)
+    {
+        await weatherService.DeleteWeather(weatherId);
+        return Results.Ok();
     }
 }
diff --git a/template/src/Placeholder.Core/Weather/WeatherRepository.cs b/template/src/Placeholder.Core/Weather/WeatherRepository.cs
@@ -11,7 +11,7 @@ internal class WeatherRepository(DbConnection connection) : IWeatherRepository
     public async Task<IEnumerable<Weather>> GetWeathers()
     {
         var query = @"
-            SELECT *
+            SELECT Date, TemperatureC, Summary
             FROM Weather
         ";
 
@@ -22,7 +22,7 @@ FROM Weather
     public async Task<Weather?> GetWeather(long id)
     {
         var query = @"
-            SELECT *
+            SELECT Date, TemperatureC, Summary
             FROM Weather
             WHERE Id = @Id
         ";