Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass the value of variable health_check_unhealthy_threshold #13

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

guillaume-dussault
Copy link
Contributor

fix: pass the value of variable health_check_unhealthy_threshold to the alb_ingress module

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

The value of the variable health_check_unhealthy_threshold is not passed and assigned in the module.

What is the new behavior?

This fixes the issue.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated tests for the changes have been added/updated.
  • Commits have been squashed (if applicable).
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).

Other information

Sup juju ಥ‿ಥ

@guillaume-dussault
Copy link
Contributor Author

Small issue with the CI!

@jbonnier jbonnier merged commit 0f27fdc into nventive:main Sep 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants