Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SG arg, SG naming and health check protocol arg #3

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

guillaume-dussault
Copy link
Contributor

@guillaume-dussault guillaume-dussault commented Oct 23, 2023

Proposed Changes

  • Change the name of the SG for a more specific value
  • Add an arg to enable the creation of the service SG (often not used)
  • Make it so the protocol of the health check fits with the protocol of the service

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

  • The name of the SG is not explicit
  • Not possible to skip the creation of the service SG
  • The protocol of the health check of the service is always HTTP

What is the new behavior?

  • The name of the SG is explicit
  • It is possible to skip the creation of the service SG
  • The protocol of the health check of the service will fit the container/service protocol

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated tests for the changes have been added/updated.
  • Commits have been squashed (if applicable).
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).

main.tf Outdated Show resolved Hide resolved
@jbonnier jbonnier merged commit 2d43ce4 into nventive:main Oct 24, 2023
3 checks passed
guillaume-dussault pushed a commit to guillaume-dussault/terraform-aws-ecs-app that referenced this pull request Oct 26, 2023
SG arg, SG naming and health check protocol arg
guillaume-dussault pushed a commit to guillaume-dussault/terraform-aws-ecs-app that referenced this pull request Oct 26, 2023
SG arg, SG naming and health check protocol arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants