Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an ecs_alarm_description variable to be passed to an unde… #7

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jbonnier
Copy link
Collaborator

@jbonnier jbonnier commented Nov 13, 2023

GitHub Issue: n/a

Proposed Changes

This change introduces a new variable to be passed to the ecs_alarms module and is required when using a ecs_alarms_*_period number that is not divisble by 60. The default description is using %d which crashes when the value passed is a decimal number.

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

When specifying a ecs_alarms_cpu_utilization_high_period lower than 60, maybe whenever that number divided by 60 doesn't return an integer, the plan/apply fails with an error message similar to:

Call to function "format" failed: unsupported value for "%d" at 39: an integer is required.

What is the new behavior?

When specifying a ecs_alarms_cpu_utilization_high_period, if that number divided by 60 doesn't return an integer, the plan/apply succeeds without an error, thanks to the new default value.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated tests for the changes have been added/updated.
  • Commits have been squashed (if applicable).
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).

Other information

n/a

@jbonnier jbonnier merged commit 9543c88 into main Nov 14, 2023
3 checks passed
@jbonnier jbonnier deleted the feat/add-ecs-alarms-description-variable branch November 14, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants