feat: Add an ecs_alarm_description
variable to be passed to an unde…
#7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: n/a
Proposed Changes
This change introduces a new variable to be passed to the
ecs_alarms
module and is required when using aecs_alarms_*_period
number that is not divisble by60
. The default description is using%d
which crashes when the value passed is a decimal number.What is the current behavior?
When specifying a
ecs_alarms_cpu_utilization_high_period
lower than60
, maybe whenever that number divided by60
doesn't return an integer, the plan/apply fails with an error message similar to:What is the new behavior?
When specifying a
ecs_alarms_cpu_utilization_high_period
, if that number divided by60
doesn't return an integer, the plan/apply succeeds without an error, thanks to the new default value.Checklist
Please check that your PR fulfills the following requirements:
Other information
n/a