Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cookie consent #9

Merged
merged 7 commits into from
Aug 13, 2024
Merged

feat: cookie consent #9

merged 7 commits into from
Aug 13, 2024

Conversation

MounirAbdousNventive
Copy link
Contributor

GitHub Issue or Internal Use Azure Devops Work Item ID:

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

What is the new behavior?

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.

Other information

@MounirAbdousNventive MounirAbdousNventive force-pushed the feat/cookie-consent branch 6 times, most recently from 3b3e08b to bf54586 Compare August 13, 2024 17:59
@MounirAbdousNventive MounirAbdousNventive merged commit 0a5bbc5 into main Aug 13, 2024
4 checks passed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suite au post dans le channel web, les gens semblent préférer string[] au lieu de Array<string>
Ça te va de faire le switch pour ta PR svp?

{
name: "i18nextLng",
description:
"Stores the language preference of the user for localization purposes.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add translations keys here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants