Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stencil): resolve validateConfig error from @stencil/[email protected] onward. #1088

Conversation

ShariefO
Copy link

@ShariefO ShariefO commented May 8, 2024

Hey!

From @stencil/[email protected] onward, the following error occurs for executors 'build', 'test', 'e2e', and 'serve': Cannot read properties of undefined (reading 'validateConfig').

This issue stems from globalThis.stencil not being properly set within the loadCoreCompiler function.

To resolve this, the loadCoreCompiler function has been updated to ensure proper initialization of globalThis.stencil by assigning the imported compiler module if globalThis.stencil is undefined.

Additionally, I have added a test case in stencil-process.spec.ts to validate the correct initialization of globalThis.stencil by loadCoreCompiler.

I have tested the fix by upgrading the '@stencil/core' package from version 4.12.6 to 4.17.0 within this repo and running the tests in stencil-process.spec.ts with and without the fix applied.

This issue has also been mentioned in #1086

Copy link

nx-cloud bot commented May 8, 2024

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit c24849d.
Please verify you are running the latest version of the NxCloud runner.

Check the Nx Cloud Source Control Integration documentation for more information.

Alternatively, you can contact us at [email protected].


Sent with 💌 from NxCloud.

@DominikPieper DominikPieper merged commit f5b8725 into nxext:main May 14, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants