-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device MCIMX6X and MCIMX7D and related i.mx drivers #53
base: main
Are you sure you want to change the base?
Add device MCIMX6X and MCIMX7D and related i.mx drivers #53
Conversation
- This files are copied from https://github.com/zephyrproject-rtos/hal_nxp/tree/master/imx and re-organized according to current folder structure. - Device headers and device specific files goes to devices/{device} folder, common drivers are put in the drivers/xx_imx driver folder according to IP. Signed-off-by: Susan Su <[email protected]>
Hi @dleach02, @mmahadevan108 please help review if the organize way of these i.mx stuff is OK and feel free to suggest, thanks in advance. |
Hi @mmahadevan108, @dleach02, kind reminder, please help check the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
device_imx.h
duplicated and put in 2 locations. Is there a common place we can add this file?
@mcuxsusan. Any thoughts on avoiding |
Hi @mmahadevan108 , sorry for my late response. Per my understanding, this device_imx.h header file is similar as our fsl_device_registers.h, just used to include the needed header file for this specific device. So, I was wondering we should have individual device_imx.h, just like our fsl_device_registers.h. I could make the content only specified for this device, is that acceptable for your side? |
I think that should work. Thank you |
@mcuxsusan Getting back to this PR. Can it be update per the above discussion. |
Hi @mmahadevan108, sorry for my late action. I will try to update this tomorrow, appreciate for your patience. |
Signed-off-by: Susan Su <[email protected]>
@mmahadevan108, please check the updated PR, thanks a lot. |
@mcuxsusan , restarting this thread as there are some PR's in Zephyr that could benefit from adding this support in the SDK. Does this PR need to be updated for the current version of the SDK? |
Hello @mmahadevan108, checking with the NPI team, these two devices are not in SDK support scope now. So, we are not able to add the two devices into the mcux-sdk repo. Not sure if you would like to have these two devices support maintain in hal_nxp. |
This files are copied from https://github.com/zephyrproject-rtos/hal_nxp/tree/master/imx
and re-organized according to current folder structure.
Device headers and device specific files goes to devices/{device}
folder, common drivers are put in the drivers/xx_imx driver folder
according to IP.
Signed-off-by: Susan Su [email protected]
Prerequisites
Describe the pull request
A clear and concise description for the change in this Pull Request and which issue is fixed.
Fixes # (issue)
Type of change (please delete options that are not relevant):
Tests
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.