Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device MCIMX6X and MCIMX7D and related i.mx drivers #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcuxsusan
Copy link
Contributor

Signed-off-by: Susan Su [email protected]

Prerequisites

  • I have checked latest main branch and the issue still exists.
  • I did not see it is stated as known-issue in release notes.
  • No similar GitHub issue is related to this change.
  • My code follows the commit guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.

Describe the pull request

A clear and concise description for the change in this Pull Request and which issue is fixed.

Fixes # (issue)

Type of change (please delete options that are not relevant):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  • Test configuration (please complete the following information):
    • Hardware setting:
    • Toolchain:
    • Test Tool preparation:
    • Any other dependencies:
  • Test executed
    Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
    • Build Test
    • Run Test

 - This files are copied from https://github.com/zephyrproject-rtos/hal_nxp/tree/master/imx
   and re-organized according to current folder structure.

 - Device headers and device specific files goes to devices/{device}
   folder, common drivers are put in the drivers/xx_imx driver folder
   according to IP.

Signed-off-by: Susan Su <[email protected]>
@mcuxsusan
Copy link
Contributor Author

Hi @dleach02, @mmahadevan108 please help review if the organize way of these i.mx stuff is OK and feel free to suggest, thanks in advance.

@mcuxsusan
Copy link
Contributor Author

Hi @mmahadevan108, @dleach02, kind reminder, please help check the PR.

Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

device_imx.h duplicated and put in 2 locations. Is there a common place we can add this file?

@mmahadevan108
Copy link
Contributor

@mcuxsusan. Any thoughts on avoiding device_imx.h duplication?

@mcuxsusan
Copy link
Contributor Author

Hi @mmahadevan108 , sorry for my late response. Per my understanding, this device_imx.h header file is similar as our fsl_device_registers.h, just used to include the needed header file for this specific device. So, I was wondering we should have individual device_imx.h, just like our fsl_device_registers.h.

I could make the content only specified for this device, is that acceptable for your side?

@mmahadevan108
Copy link
Contributor

I think that should work. Thank you

@mmahadevan108
Copy link
Contributor

@mcuxsusan Getting back to this PR. Can it be update per the above discussion.

@mcuxsusan
Copy link
Contributor Author

Hi @mmahadevan108, sorry for my late action. I will try to update this tomorrow, appreciate for your patience.

@mcuxsusan
Copy link
Contributor Author

@mmahadevan108, please check the updated PR, thanks a lot.

@mmahadevan108
Copy link
Contributor

@mcuxsusan , restarting this thread as there are some PR's in Zephyr that could benefit from adding this support in the SDK. Does this PR need to be updated for the current version of the SDK?

@mcuxsusan
Copy link
Contributor Author

Hello @mmahadevan108, checking with the NPI team, these two devices are not in SDK support scope now. So, we are not able to add the two devices into the mcux-sdk repo. Not sure if you would like to have these two devices support maintain in hal_nxp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants