This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
Proposal: Use packages on Github registry to share code between repositories #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal: Use packages on Github registry to share code between repositories
This is proposal for starting to share code across repositories by publishing certain repositories as a package on the github package registry.
Current situation
At the moment we have 3 ways to share code between repositories:
Each of these ways has subtle disadvantages.
Proposed solution
Publish shared repositories as npm package in the github package repository. Automate publishing with github actions.
Reasons for having a package
Reasons to use the github registry (and not npm)
Reasons for using github actions
Technical solution: We could go with https://github.com/marketplace/actions/publish-to-npm which means that we just increase the version number in package.json. The action will then automatically publish a new package and add a git tag.
Approach
I would start setting up the infrastructure to publish eslint-config-getsafe. Once this is done and we are happy with it we can consider using it for the ui-kit (or other shared code, see https://hellogetsafe.atlassian.net/browse/GET-3502)