Ask user to confirm info before creating Install #609
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 94.18% 94.23% +0.04%
==========================================
Files 80 80
Lines 3251 3277 +26
==========================================
+ Hits 3062 3088 +26
Misses 189 189 ☔ View full report in Codecov by Sentry. |
State is a dropdown and Zip breaks if it's wrong.
|
Idea: Instead of logging PII, add some marker to the join form log expressing that there was a problem. That would require appending to an existing S3 object in meshforms, since it would save the submission immediately upon entry. |
|
Yeah i think i already thought of this but http code |
|
I think now all's I gotta do is update Meshforms. Having just spent 30+ hours learning more React, I have i d e a s. |
|
Maybe I could include the PII in the Notes of the created user as well...? |
| logging.warning(f"Changed street_address: {r.street_address} != {nyc_addr_info.street_address}") | ||
| changed_info["street_address"] = nyc_addr_info.street_address | ||
|
|
||
| if r.city != nyc_addr_info.city: |
There was a problem hiding this comment.
Can the ZIP or state mismatch? Or are we excluding that possibility already above?
There was a problem hiding this comment.
They totally can, but I think I have a test for it now, (at least with NJ state but NYC address). I think it's acceptable to have this validation in the backend with the rest of our address code, but maybe we should have some explicit check for it so we can return a more specific error. Right now, it just tells the member that Non-NYC registrations are not accepted.
|
This is almost done, but I'm seeing some inconsistencies with how the phone number parsing works and how it is stored in the DB. For example, I see every phone number stored like |
|
Maybe Django is formatting it after the fact? IDK I need to do some more testing. |
|
| @@ -961,7 +961,7 @@ def test_member_moved_and_used_non_primary_email_join_form(self): | |||
| f"but got {response3.status_code}.\n Response is: {response3.content.decode('utf-8')}", | |||
| ) | |||
|
|
|||
| validate_successful_join_form_submission(self, "Valid Join Form", s, response3, expected_member_count=2) | |||
| validate_successful_join_form_submission(self, "Valid Join Form", s, response3, expected_member_count=3) | |||
There was a problem hiding this comment.
It's 5AM so I'm making a wild fucking guess, but this should be making 3 instead of 2 now, since phone number is no longer deduped
Closes nycmeshnet/meshforms#56