Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask user to confirm info before creating Install #609

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
fb5d197
fix 500 on bldg
WillNilges Sep 23, 2024
33fb419
Store changed info and print something
WillNilges Sep 23, 2024
4715fce
fancy
WillNilges Sep 23, 2024
e35f2ff
Now I gotta update all these tests :(
WillNilges Sep 24, 2024
f6e3b5f
This feels very brittle
WillNilges Sep 25, 2024
dfaa79c
That's maybe a little better.
WillNilges Sep 25, 2024
bbde722
Test cases
WillNilges Sep 25, 2024
07fa3d0
update tests
WillNilges Sep 25, 2024
8367cb6
Add trust_me_bro
WillNilges Sep 25, 2024
2592a49
Add trust_me_bro to test data
WillNilges Sep 26, 2024
bdc372e
format
WillNilges Sep 26, 2024
af407a4
set trust_me_bro
WillNilges Sep 26, 2024
11515d6
checkpoint
WillNilges Sep 26, 2024
9e873d3
computers
WillNilges Sep 26, 2024
ae222c6
Formatting?
WillNilges Sep 30, 2024
afbfcd0
Parsed City
WillNilges Sep 30, 2024
8ea2a0b
Remove State + Zip warning
WillNilges Sep 30, 2024
33fcb21
Fix import crash (#598)
Andrew-Dickinson Sep 23, 2024
07377b1
Make name dedupe logic case-insensitive & prefer longer names (#556)
Andrew-Dickinson Sep 23, 2024
a3a91b4
Add django-simple-history (#599)
Andrew-Dickinson Sep 23, 2024
c89b2fb
Change ticket number to charfield (#562)
Andrew-Dickinson Sep 24, 2024
0ee526c
rename all instances of prod1 -> prod + docs cleanup (#618)
james-otten Sep 29, 2024
f125f03
rolling restart stateful sets (#620)
james-otten Sep 29, 2024
c4ada29
only backup 'default' (#621)
james-otten Sep 29, 2024
31583aa
Add new encrypted volume (#615)
james-otten Oct 2, 2024
7771b94
use the new one (#623)
james-otten Oct 2, 2024
0014070
Complete volume swap (#616)
james-otten Oct 2, 2024
d158dcc
Fix 500 on panorama building save (for real this time) (#622)
WillNilges Oct 2, 2024
c050532
Fix: NYC addresses are sent to random New England towns (#604)
Andrew-Dickinson Oct 6, 2024
0ed6ff0
Import fixes (#607)
Andrew-Dickinson Oct 6, 2024
a4790c2
Fix: nodes without active installs are hidden on the map (#606)
Andrew-Dickinson Oct 6, 2024
8c32592
Fix: nodes is required to edit building object (#600)
Andrew-Dickinson Oct 6, 2024
fa84ad0
Fix: exports get captured by captive nav and don't download (#601)
Andrew-Dickinson Oct 6, 2024
776525d
Add missing assert_ to called_once_with (#619)
Andrew-Dickinson Oct 6, 2024
47d22f6
Fix: crash due to link sheet format change (#626)
Andrew-Dickinson Oct 6, 2024
603772b
Fix: zip code validation only applies to non-NYC addresses (#629)
Andrew-Dickinson Oct 6, 2024
072c27f
got it
WillNilges Oct 10, 2024
17c292d
Update submission format
WillNilges Oct 11, 2024
554590e
get tests working
WillNilges Oct 12, 2024
f76fba4
computers
WillNilges Oct 12, 2024
98969e3
lint
WillNilges Oct 12, 2024
fd80064
zip
WillNilges Oct 12, 2024
1ec1c46
black
WillNilges Oct 12, 2024
9412847
Check that we say no to NJ properly:
WillNilges Oct 13, 2024
76d3743
move check
WillNilges Oct 13, 2024
2a6bc8f
fix thingie
WillNilges Oct 13, 2024
3db27d4
Add another test
WillNilges Oct 13, 2024
56e5009
Default to str when dumping json object
WillNilges Oct 13, 2024
77177e5
lint
WillNilges Oct 13, 2024
3b5ee9f
Merge branch 'main' into wdn/202
WillNilges Oct 13, 2024
da8ad9d
lint
WillNilges Oct 13, 2024
610553e
email
WillNilges Oct 13, 2024
0a58c5e
lint
WillNilges Oct 13, 2024
1e9c1e3
insanity
WillNilges Oct 13, 2024
6e35cb7
email
WillNilges Oct 13, 2024
f800b3b
Wild fucking guess, but this test should now create 3 members instead…
WillNilges Oct 13, 2024
adcb98a
fix git fuckery
WillNilges Oct 13, 2024
af4203f
Test nyc join form but nj zip
WillNilges Oct 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/meshapi/tests/test_join_form.py
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,7 @@ def test_member_moved_and_used_non_primary_email_join_form(self):
f"but got {response3.status_code}.\n Response is: {response3.content.decode('utf-8')}",
)

validate_successful_join_form_submission(self, "Valid Join Form", s, response3, expected_member_count=2)
validate_successful_join_form_submission(self, "Valid Join Form", s, response3, expected_member_count=3)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 5AM so I'm making a wild fucking guess, but this should be making 3 instead of 2 now, since phone number is no longer deduped


self.assertNotEqual(
str(member_object.id),
Expand Down
Loading