Add "Autocomplete from ..." button to Device, Sector, Node and Building #396
Conversation
Andrew-Dickinson
force-pushed
the
andrew/add-button-fixes
branch
from
0a09ec7
to
d0563ab
Compare
Andrew-Dickinson
force-pushed
the
andrew/wip-admin-auto-geo-coord
branch
from
9cb150a
to
7419d1d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 94.76% 94.93% +0.17%
==========================================
Files 101 103 +2
Lines 5025 5155 +130
==========================================
+ Hits 4762 4894 +132
+ Misses 263 261 -2 ☔ View full report in Codecov by Sentry. |
Andrew-Dickinson
force-pushed
the
andrew/wip-admin-auto-geo-coord
branch
from
7419d1d
to
d06ed17
Compare
|
|
# Conflicts: # src/meshapi/admin/building.py # src/meshapi/views/geography.py
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
A little odd that we're integration testing their API, but pop off.
There was a problem hiding this comment.
We're not integration testing their API. This is a mocked response where our testing framework pretends to be their API. It actually allows the opposite, for our tests to be fully independent of the city's API
src/meshapi/views/geography.py
Outdated
| except ValueError: | ||
| return Response( | ||
| { | ||
| "detail": "Non-NYC registrations are not supported at this time. Check back later, " |
There was a problem hiding this comment.
Small Nit: Maybe we shouldn't say "check back later." I know we've been doing that for like a year, but it's probably more productive to just say "contact support."
There was a problem hiding this comment.
I can change this, but really this should be handled in the frontend and nobody should see this message
Adds a button to the following admin pages:
When clicked, it automatically populates the geospatial coordinates (and DOB BIN where applicable) from the appropriate source. For Buildings, it uses the entered address (via a lookup to the city APIs). For Nodes, it uses the associated building (selecting the first one arbitrarily if there is more than one). For devices and sectors, it uses the associated node.
Example:
Screen.Recording.2024-07-06.at.14.58.48.mov
Closes #307