Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install-create event handlers #608

Merged
merged 17 commits into from
Oct 12, 2024
Merged

Conversation

Andrew-Dickinson
Copy link
Member

Brings the logic for creating slack messages and OSTicket tickets, which was contained in a separate service, into the meshdb monolith

Also fix an issue with admin UI redirects

Fixes #532

@Andrew-Dickinson Andrew-Dickinson marked this pull request as draft September 24, 2024 02:55
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 96.52174% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@cc5f067). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/meshapi/util/events/osticket_creation.py 92.98% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage        ?   94.15%           
=======================================
  Files           ?       79           
  Lines           ?     3215           
  Branches        ?        0           
=======================================
  Hits            ?     3027           
  Misses          ?      188           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-Dickinson Andrew-Dickinson marked this pull request as ready for review October 6, 2024 18:00
@Andrew-Dickinson
Copy link
Member Author

Moved redirect fix to a standalone PR: #637

Copy link
Collaborator

@WillNilges WillNilges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hate osticket so much

@Andrew-Dickinson Andrew-Dickinson enabled auto-merge (squash) October 12, 2024 17:06
@Andrew-Dickinson Andrew-Dickinson merged commit 6b2f203 into main Oct 12, 2024
12 checks passed
@Andrew-Dickinson Andrew-Dickinson deleted the andrew/install-create-events branch October 12, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update and test automatic ticket creation
3 participants