Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactivate Devices & Links that are deleted in UISP #630

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

Andrew-Dickinson
Copy link
Member

@Andrew-Dickinson Andrew-Dickinson commented Oct 6, 2024

Add loop to the end of the ongoing UISP import which validates all of the links and devices we expect are still around in UISP, marking them inactive if not

Closes #570

@Andrew-Dickinson Andrew-Dickinson force-pushed the andrew/inactivate-deleted-devices branch from fee33b7 to 2054fdb Compare October 6, 2024 20:14
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (6b2f203) to head (c5add0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
+ Coverage   94.15%   94.18%   +0.03%     
==========================================
  Files          79       79              
  Lines        3215     3235      +20     
==========================================
+ Hits         3027     3047      +20     
  Misses        188      188              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-Dickinson Andrew-Dickinson enabled auto-merge (squash) October 12, 2024 17:32
@Andrew-Dickinson Andrew-Dickinson merged commit 7b21c21 into main Oct 12, 2024
10 checks passed
@Andrew-Dickinson Andrew-Dickinson deleted the andrew/inactivate-deleted-devices branch October 12, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links and Devices deleted from UISP are not marked inactive in MeshDB
3 participants