Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: import script creates empty "husk" members #633

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix: import script creates empty "husk" members #633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/meshdb/utils/spreadsheet_import/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,17 @@ def main():
building = get_or_create_building(row, addr_parser, dropped_modifications.append)
if not building:
skipped[row.id] = "Unable to parse address"
if (
new
and not member.all_email_addresses
and not member.all_phone_numbers
and not member.name
and not member.notes
):
# If this member object stores no contact information, and is not going to be
# used for an install because of an invalid address, remove the member object
# to avoid cluttering the DB with "husk" members that are entirely blank
member.delete()
continue

node = get_or_create_node(row)
Expand Down
Loading