Use a fresh connection on every request #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be using a shared
requests.Session()
object across all requests that a client makes. If the client (and therefore the session) is shared across multiple threads or greenlets we can encounter a race condition that causes the following error:This happens because the session maintains a connection pool for each host (keep-alive). If a connection is closed by the server around the same time a thread tries to make a new request using that connection, then the new request will be made on the already closed connection.
This PR simply removes the
session
member and lets the requests package make a new connection on every request.