clippy

common/credentials/src/coconut/bandwidth/issuance.rs

@@ -23,7 +23,7 @@ use zeroize::{Zeroize, ZeroizeOnDrop};
 
 pub use nym_validator_client::nyxd::{Coin, Hash};
 
-#[derive(Zeroize, ZeroizeOnDrop, Serialize, Deserialize)]
+#[derive(Serialize, Deserialize)]
 pub enum BandwidthCredentialIssuanceDataVariant {
     TicketBook(BandwidthVoucherIssuanceData),
     FreePass,
@@ -298,18 +298,3 @@ fn make_recovery_bincode_serializer() -> impl bincode::Options {
         .with_big_endian()
         .with_varint_encoding()
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    fn assert_zeroize_on_drop<T: ZeroizeOnDrop>() {}
-
-    fn assert_zeroize<T: Zeroize>() {}
-
-    #[test]
-    fn credential_is_zeroized() {
-        assert_zeroize::<IssuanceBandwidthCredential>();
-        assert_zeroize_on_drop::<IssuanceBandwidthCredential>();
-    }
-}

common/credentials/src/coconut/bandwidth/voucher.rs

@@ -37,15 +37,13 @@ impl BandwidthVoucherIssuedData {
     }
 }
 
-#[derive(Zeroize, ZeroizeOnDrop, Serialize, Deserialize)]
+#[derive(Serialize, Deserialize)]
 pub struct BandwidthVoucherIssuanceData {
     /// the plain value (e.g., bandwidth) encoded in this voucher
     // note: for legacy reasons we're only using the value of the coin and ignoring the denom
-    #[zeroize(skip)]
     value: u128,
 
     /// the hash of the deposit transaction
-    #[zeroize(skip)]
     deposit_tx_hash: Hash,
 
     /// base58 encoded private key ensuring the depositer requested these attributes

common/nym_offline_compact_ecash/src/scheme/keygen.rs

@@ -626,3 +626,21 @@ pub fn ttp_keygen(threshold: u64, num_authorities: u64) -> Result<Vec<KeyPairAut
 
     Ok(keypairs)
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    fn assert_zeroize_on_drop<T: ZeroizeOnDrop>() {}
+
+    fn assert_zeroize<T: Zeroize>() {}
+
+    #[test]
+    fn secret_key_is_zeroized() {
+        assert_zeroize::<SecretKeyAuth>();
+        assert_zeroize_on_drop::<SecretKeyAuth>();
+
+        assert_zeroize::<SecretKeyUser>();
+        assert_zeroize_on_drop::<SecretKeyUser>();
+    }
+}