Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Data] Config deserialization bug fix #5126

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

simonwicky
Copy link
Contributor

@simonwicky simonwicky commented Nov 13, 2024

Fixes a bug where a None value was serialized into an empty string, and incorrectly deserialized into a Some variant.


This change is Reviewable

@simonwicky simonwicky requested a review from jstuczyn November 13, 2024 11:04
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 0:12am
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 0:12am
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 0:12am

@simonwicky simonwicky added this to the Crunch milestone Nov 13, 2024
@jstuczyn jstuczyn merged commit b8c1014 into develop Nov 14, 2024
21 checks passed
@jstuczyn jstuczyn deleted the simon/stats_bugfix branch November 14, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants