Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nyx Chain Watcher #5274

Merged
merged 37 commits into from
Dec 19, 2024
Merged

Nyx Chain Watcher #5274

merged 37 commits into from
Dec 19, 2024

Conversation

mmsinclair
Copy link
Contributor

@mmsinclair mmsinclair commented Dec 17, 2024 •
edited
Loading

This change is Reviewable

@mmsinclair mmsinclair force-pushed the feature/nyx-chain-watcher branch from 6f4f7c0 to 3c97e7a Compare December 17, 2024 15:03
@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 3:38pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 3:38pm

@mmsinclair mmsinclair changed the title Feature/nyx chain watcher Nyx Chain Watcher Dec 17, 2024
@mmsinclair mmsinclair marked this pull request as ready for review December 17, 2024 15:06
@mmsinclair mmsinclair added this to the Hu milestone Dec 17, 2024
@mmsinclair mmsinclair requested a review from jstuczyn December 17, 2024 15:06
@pwnfoo pwnfoo force-pushed the feature/nyx-chain-watcher branch from ba925ff to b7e6895 Compare December 19, 2024 03:56
jstuczyn
jstuczyn approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@jstuczyn jstuczyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I just looked at the scraper code changes not the chain watcher (lmk if you want me to review that)

common/nyxd-scraper/src/scraper/mod.rs Show resolved Hide resolved
nym-validator-rewarder/src/config/mod.rs Show resolved Hide resolved
pwnfoo and others added 21 commits December 19, 2024 14:10
@pwnfoo @mmsinclair
nyxd-scraper: add config to make pre-commit storage optional
c99a240
@pwnfoo @mmsinclair
clippy
80f965a
@pwnfoo @mmsinclair
fix review comments
a884aee
@pwnfoo @mmsinclair
observatory 0.1
868d743
@mmsinclair
nyxd-scraper: add optional starting height parameter to scrape before…
d951ea9 
… listening for new blocks
@mmsinclair
data-observatory: renamed transactions to payments because there …
6010de9 
…is already `transaction` in the base scraper schema
@mmsinclair
Move nym-data-observatory (v0) to nyx-chain-watcher
cf6f437
@mmsinclair
Add config, overrides and CLI
5728750
@mmsinclair
Remove migration from seed app
2351651
@mmsinclair
Add example to README
df004f8
@mmsinclair
init saves example config
5b6ae39
@mmsinclair
parse message index and process all log entries
156e892
@mmsinclair
Add Dockerfile and workflow to build
39f525e
@mmsinclair
Fix docker entry point and bump version
541d46e
@jstuczyn @mmsinclair
implemented starting block logic inside the chain scraper itself
d8a6ca4
@mmsinclair
Bump version
a6f4f01
@mmsinclair
Bump version
2b26a88
@jstuczyn @mmsinclair
allow conversion from CometBFT block subscription
1890367
@jstuczyn @mmsinclair
explicitly build websocket client in 0.37 compat mode
60e8e53
@jstuczyn @mmsinclair
extra logs
be18582
@jstuczyn @mmsinclair
even more logs
98a4cb4
@mmsinclair mmsinclair force-pushed the feature/nyx-chain-watcher branch from b7e6895 to bad85ab Compare December 19, 2024 14:11
@pwnfoo pwnfoo force-pushed the feature/nyx-chain-watcher branch from 0adf1ba to 6437354 Compare December 19, 2024 15:00
@pwnfoo pwnfoo force-pushed the feature/nyx-chain-watcher branch from 5f5267f to d0722e5 Compare December 19, 2024 15:38
@tommyv1987 tommyv1987 merged commit 2fab3f1 into develop Dec 19, 2024
18 checks passed
@tommyv1987 tommyv1987 deleted the feature/nyx-chain-watcher branch December 19, 2024 17:34
@tommyv1987
Copy link
Contributor

Out of scope for Hu testing, internal tool. Will review at later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwnfoo pwnfoo pwnfoo left review comments

@jstuczyn jstuczyn jstuczyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Hu
Development

Successfully merging this pull request may close these issues.
4 participants
@mmsinclair @tommyv1987 @pwnfoo @jstuczyn