Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose proof base64 conversion #1928

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Conversation

mitschabaude
Copy link
Collaborator

@mitschabaude mitschabaude commented Nov 27, 2024

low-level method exposed to have more flexibility for how to serialize proofs

I need this in zksecurity/mina-credentials#82 to get a synchronous version of Proof.fromJSON()

Copy link
Member

@Geometer1729 Geometer1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitschabaude
Copy link
Collaborator Author

that changelog CI job is effective :D

Copy link
Contributor

@Shigoto-dev19 Shigoto-dev19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@mitschabaude
Copy link
Collaborator Author

@Trivo25 I think this is ready for code owner approval

@mitschabaude mitschabaude merged commit 996ebb3 into main Dec 4, 2024
28 checks passed
@mitschabaude mitschabaude deleted the feature/expose-proof-base64 branch December 4, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants