ZkPrograms QoL improvements #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
requested review from
45930 and
Geometer1729
and removed request for
a team
|
Ready for review |
|
note: the commonjs test failure just seems to be a runner problem |
|
Your first two bullets should probably be added to CHANGELOG.md CI is supposed to catch when PRs don't update the changelog, not sure why it didn't here. |
45930
reviewed
Dec 12, 2024
45930
reviewed
Dec 12, 2024
| @@ -1112,7 +1126,7 @@ type Infer<T> = T extends Subclass<typeof ProofBase> | |||
|
|
|||
| type TupleToInstances<T> = { | |||
| [I in keyof T]: Infer<T[I]>; | |||
| } & any[]; | |||
| }; | |||
45930
approved these changes
Dec 12, 2024
Trivo25
approved these changes
Dec 13, 2024
|
updated the PR incl. changelog, just waiting for base PR to merge |
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small collection of QoL improvements around ZkProgram:
TupleToInstances<>type so that it gets fully resolved by intellisense, i.e. we now see a normal method signature when hovering over ZkProgram methodsmaxProofsVerified()and theProofclass directly on the ZkProgram