Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix git diff to include .wasm files #1961

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Geometer1729
Copy link
Member

@Geometer1729 Geometer1729 commented Dec 19, 2024

Fixes issue with #1958 where wasm files get summarized in the diff to
Binary files a/compiled/node_bindings/plonk_wasm_bg.wasm and b/compiled/node_bindings/plonk_wasm_bg.wasm differ
and then git apply doesn't work like you'd want.

o1js-bindings changes: o1-labs/o1js-bindings#322

@Geometer1729 Geometer1729 marked this pull request as ready for review December 19, 2024 21:56
@Geometer1729 Geometer1729 requested a review from a team as a code owner December 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants