range32 checking for added to mips #2733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## sai/add-range32-check #2733 +/- ##
=========================================================
- Coverage 72.49% 72.47% -0.02%
=========================================================
Files 247 247
Lines 57734 57741 +7
=========================================================
- Hits 41852 41849 -3
- Misses 15882 15892 +10 ☔ View full report in Codecov by Sentry. |
| @@ -168,6 +168,10 @@ impl<Fp: Field> InterpreterEnv for Env<Fp> { | |||
| Self::Variable::constant(Operations::from(Literal(Fp::from(x)))) | |||
| } | |||
|
|
|||
| fn constant64(x: u64) -> Self::Variable { | |||
| Self::Variable::constant(Operations::from(Literal(Fp::from(x)))) | |||
There was a problem hiding this comment.
Note that you can always use Self::Variable::from(x as u64).
dannywillems
requested changes
Oct 27, 2024
|
See #2732 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have yet to add the contraints for this PR, I am currently unsure what to constrain as 32 and 64 bits.