branch less than unsigned #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2860 +/- ##
==========================================
- Coverage 72.19% 72.15% -0.05%
==========================================
Files 259 259
Lines 61488 61513 +25
==========================================
- Hits 44393 44386 -7
- Misses 17095 17127 +32 ☔ View full report in Codecov by Sentry. |
|
|
||
| let rd_scratch = env.alloc_scratch(); | ||
| let less_than = unsafe { env.test_less_than(&local_rs1, &local_rs2, rd_scratch) }; | ||
| // debug!("less_than: {:?}", less_than); |
| let local_rs1 = env.read_register(&rs1); | ||
| let local_rs2 = env.read_register(&rs2); | ||
|
|
||
| let rd_scratch = env.alloc_scratch(); |
There was a problem hiding this comment.
Can we keep it in the scope of less_than, please?
dannywillems
approved these changes
Dec 24, 2024
dannywillems
force-pushed
the
sai/branch-gte
branch
from
76ba34a to
5efc2f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.