Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/riscv32im: simplify assert_boolean #2908

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

dannywillems
Copy link
Member

No description provided.

@dannywillems dannywillems requested a review from svv232 December 23, 2024 20:29
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.31%. Comparing base (037f60a) to head (a0177ab).
Report is 258 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/interpreters/riscv32im/constraints.rs 0.00% 2 Missing ⚠️
o1vm/src/interpreters/riscv32im/witness.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2908   +/-   ##
=======================================
  Coverage   72.30%   72.31%           
=======================================
  Files         259      259           
  Lines       61388    61384    -4     
=======================================
+ Hits        44386    44388    +2     
+ Misses      17002    16996    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dannywillems dannywillems force-pushed the dw/riscv32im-check-boolean branch from b12d785 to a0177ab Compare December 24, 2024 12:32
@dannywillems dannywillems merged commit faa6062 into master Dec 24, 2024
8 checks passed
@dannywillems dannywillems deleted the dw/riscv32im-check-boolean branch December 24, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants