o1vm/riscv32im: decrease the number of required columns #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try with 38, and fibonacci will fail. It might need to be increased in the future if you see that the current testsuite doesn't cover the whole instruction set.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dw/simply-prettifying #2914 +/- ##
=========================================================
- Coverage 73.37% 73.35% -0.02%
=========================================================
Files 259 259
Lines 61553 61553
=========================================================
- Hits 45166 45155 -11
- Misses 16387 16398 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try with 38, and fibonacci will fail.
It might need to be increased in the future if you see that the current testsuite doesn't cover the whole instruction set.