Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to support dear-imgui 1.2.2 ; additional arguments to childWindow #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noinia
Copy link

@noinia noinia commented Nov 18, 2021

Cool project! It seems that this no longer builds with the latest version of dear-imgui available on hackage. The PR provides two fixes that allow it to compile again. I did introduce some new intermediate "config" data type to pass newChildWindow since that seemed more reasonable than have 5 arguments, but if you rather have separate arguments that can be refactored.

@o1lo01ol1o
Copy link
Owner

Thanks! It looks like the nix sources will need to be updated to get a more recent hash of hackage. You can use niv-update if you have niv installed or use these pins for haskell.nix.

        "rev": "fe40c2aed052a54bb05ba38c5b74ff8feaac1df3",
        "sha256": "04b0w28xfna1qxdiipjwa5cwbq38fd7mn1pa2451n79anly74ljm",

I did this as a proof of concept but didn't get so much use out of it yet. Let me know if you have any improvements to the ergonomics.

@noinia
Copy link
Author

noinia commented Nov 22, 2021

I don't have niv or nix installed. I just built it with cabal and it just worked.

In terms of ergonomics, I will open issues and PR's if I have any suggestions or improvements in mind. So far I didn't have time to actually do anything with it (other than get it to build) either (Hopefully that will change soon.) Apparently the api in c-bindings themselves is also still a bit of work in progress to see what works best (see e.g. haskell-game/dear-imgui.hs#33)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants