Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopcornFX: FX_EnergyBallTrap_BuildUp and FX_EnergyBallTrap_Projectile sort fixes #418

Closed

Conversation

HugoPKFX
Copy link

To partially address PopcornFX/O3DEPopcornFXPlugin#43

Fixed source effects that were incorrectly configured (used a sort by custom sort key, the key was ignoring additional components required by the sorter to work propery - emitter location for instance).

To check in the level, this should help.

Unrelated to this fix but I also re-captured the static/animated thumbnails for FX_MalfunctionningShieldGenerator_Explosion
8oeWNwQWQN

Note: to review/merge after reviewing/merging #417 to avoid merge issues (I did those modifications after modifications from this other PR).

@mbalfour-amzn
Copy link
Contributor

You'll need to fix the DCO signing on your commits.

@HugoPKFX
Copy link
Author

Hi @mbalfour-amzn ,

Sorry, re-created a different PR with the commit correctly signed this time: #422

@HugoPKFX HugoPKFX closed this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants