Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay after patching the current host #433

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhoogfr
Copy link

@dhoogfr dhoogfr commented Feb 26, 2022

Add delay after patching the current host, before continuing with the next host

After patching a host, it takes some time before that host (after rebooting) is a valid target again for guests to be migrated to.
With a 2 node cluster, this can cause the patching of the second host to fail because the guests cannot be migrated of that host or to cause the guests to be shutdown (depending on the used parameters).
This can be avoided by adding a delay (controlled by the wait_before_next_upgrade parameter, defaulting to 5 minutes) before continuing with the next host

… next host

Add delay after patching the current host, before continuing with the next host
After patching a host, it takes some time before that host (after rebooting) is a valid target again for guests to be migrated to.
With a 2 node cluster, this can cause the patching of the second host to fail because the guests cannot be migrated of that host or to cause the guests to be shutdown (depending on the used parameters).
This can be avoided by adding a delay (controlled by the wait_before_next_upgrade parameter, defaulting to 5 minutes) before continuing with the next host
@dhoogfr dhoogfr requested a review from mnecas as a code owner February 26, 2022 09:46
@dhoogfr
Copy link
Author

dhoogfr commented Mar 8, 2022

Hi,

I noticed that one build failed because of a missing changelog?
Do I need to provide something for this?

@mnecas
Copy link
Member

mnecas commented Mar 8, 2022

Hi @dhoogfr,
thanks for the patch!
I'm not sure about the use-case(don't like to see adding wait).
If the host upgrade starts before it should I think it should be addressed in the ovirt_host module when sending the upgrade request and waiting for it to finish.
(the gluster delay is for specific case)
https://github.com/oVirt/ovirt-ansible-collection/blob/master/plugins/modules/ovirt_host.py#L584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants