upgrade k8s to 1.28 #153
Closed
upgrade k8s to 1.28 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Gateway dependencies with
go get sigs.k8s.io/[email protected]go get k8s.io/[email protected]Issue 1: Changes in
manager.OptionsStructureIn
controller-runtimeversion 0.15.x, themanager.Options.Portfield, which was used to specify the Webhook port, was removed. All Webhook-related configurations were consolidated into theWebhookServerstructure, and direct configuration is now done usingwebhook.NewServer. In version 0.16.x, fields related to metrics were also removed and replaced with a unifiedmetricsserver.Optionsstructure. Consequently, some code in themainfunction was modified for compatibility.Issue 2: Unit Testing
The new version of
client-gohas updated its serialization logic, which affects the ordering ofListresults compared to previous versions. In theTest Cluster APItests, it now sorts the results before comparing them.