fix static code scan (#367)

oap-project · Jul 26, 2023 · 33086a8 · 33086a8
1 parent 9a77b96
commit 33086a8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/core/agent/src/main/java/org/apache/spark/raydp/Agent.java b/core/agent/src/main/java/org/apache/spark/raydp/Agent.java
@@ -51,11 +51,14 @@ public static void premain(String agentArgs, Instrumentation inst)
 
     File parentDir = new File(logDir);
     if (!parentDir.exists()) {
-      parentDir.mkdirs();
+      boolean flag = parentDir.mkdirs();
+      if (!flag) {
+        throw new RuntimeException("Error create log dir.");
+      }
     }
 
     File logFile = new File(parentDir, "/slf4j-" + pid + ".log");
-    try (PrintStream ps = new PrintStream(logFile)) {
+    try (PrintStream ps = new PrintStream(logFile, "UTF-8")) {
       System.setOut(ps);
       System.setErr(ps);
       // slf4j binding

diff --git a/core/agent/src/main/java/org/slf4j/impl/StaticLoggerBinder.java b/core/agent/src/main/java/org/slf4j/impl/StaticLoggerBinder.java
@@ -92,6 +92,7 @@ public class StaticLoggerBinder implements LoggerFactoryBinder {
               .getLocation().toURI().toString();
           sb.append(" from ").append(loc);
         } catch (Exception e) {
+          e.printStackTrace();
         }
       } else {
         sb.append("failed");