Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade deps, new prefix option, cleaning and typos #15

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

GreyXor
Copy link

@GreyXor GreyXor commented Feb 22, 2024

Hello, this PR contains a few improvements:

  • An update of all dependencies
  • A few typographical corrections
  • use of any rather than interface{} or http.NoBody, rather than nil
  • A new prefix option

This new prefix option is useful when you have an API whose server spec contains a subfolder. In my case, it's /api. But as I register my api with server.RegisterHandlersWithBaseURL(s.EchoServer, server.NewStrictHandler(s.APIService.API, nil), "/api").
The prefix is not visible to the router, so the validator can't see it either. Setting this new option to /api virtually removes the prefix. And makes the validator work properly.

close: #11

@GreyXor GreyXor requested a review from a team as a code owner February 22, 2024 10:25
@GreyXor
Copy link
Author

GreyXor commented Jun 17, 2024

@jamietanna gentle ping, can I have your input here ?

@GreyXor
Copy link
Author

GreyXor commented Nov 29, 2024

@jamietanna hello ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sub path support
1 participant