Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Initial Sonargraph model for OASP4j (fixes #125) #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tlueecke
Copy link

@tlueecke tlueecke commented Sep 1, 2017

This PR provides an initial version of a sonargraph model. Since we seem to have some architecture violations in the sample, it also includes virtual refactoring proposals for fixing those.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config is specific for the restaurant app which is deprecated and will be deleted soon. Further we have modeled the same with SonarQube (via ArchitecturalConstraint rules). We should figure out what are the differences and added values of SonarGraph. IMHO with the planned extension to SonarQube this will all be superseded. Should we really add this then???

@@ -0,0 +1,4 @@
<?xml version="1.0" ?>
<analyzerConfiguration version="9.4.2.446" analyzer="ArchitectureCheck">
<stringEntry value="" name="./components.arc"></stringEntry>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peanuts but OASP indentation is 2 spaces not 4.

@tlueecke
Copy link
Author

tlueecke commented Sep 5, 2017

@hohwille I would definitely not enforce usage of Sonargraph - it being a commercial product being one of the main reasons. However, Sonargraph has a different approach as far as I can see in that you define your architecture not by negation of prohibited dependencies. This makes the architecture IMHO more understandable and easier to maintain - especially for larger projects.

However, recommending to use SonarQube as the default would also be for me the way to go. This contribution was rather thought of as an opt-in feature for those probjects like mine, where the customer uses Sonargraph as a the standard for monitoring the architecture.

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants