Update model.js #34
Open
Update model.js #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
your example was broken in so many places... i fixed, following the logic I saw there, but the last one cannot even be fixed, its a contradiction - you return nothing from the query, and trying to process the result...
|
Also, returning things like: return users.length ? users[0] : false;is generally a bad idea. |
|
Missed one thing, the last: yield pg.noneshould also become yield db.none |
|
Thanks for the PR! I'll take a look at it during the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
your example was broken in so many places...
I tried to fix it, following the logic I saw there, but the last one cannot even be fixed, its a contradiction - you return nothing from the query, and trying to process the result...