Update class-obenland-wp-approve-user.php #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
English language corrections and simplifications. No need to specify who or what role approves new user registrations.
|
Thanks for your suggestions! How necessary do you feel these changes are? They'll invalidate all translations… |
|
It's definitely not essential. It doesn't change the meaning much; it just makes the message shorter and (I think) clearer by saying less. Describing a back-end process in a notification is a generally bad idea, IMO. It's giving the user too much information about a security process that not every site may follow. For example, I might allow a different (non-administrator) role group or individual to approve new user registrations... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
English language corrections and simplifications. No need to specify who or what role approves new user registrations.