-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the @abstract
attribute seems to be redundant
#3529
Comments
@maxonfjvipon WDYT? |
@yegor256 the function checks the presence of <xsl:function name="eo:abstract" as="xs:boolean">
<xsl:param name="o" as="element()"/>
<xsl:sequence select="not(exists($o/@base)) and (exists($o/o) or $o/@atom or $o/@abstract)"/>
</xsl:function> I'm not sure we can remove the attribute because there's no unique combination of other mandatory attributes like |
@yegor256 or no. Actually if object does not have |
@maxonfjvipon yes, seems to be correct: no
|
@yegor256 even |
@maxonfjvipon let's get rid of it! |
@yegor256 the problem appeared: void attributes also don't have
Here at the level of XMIR there's no difference between <o line="6" name="x" pos="1"/>
<o line="8" name="y" pos="2"/> |
@maxonfjvipon both of them are formations, aren't they? In our current XMIR semantic, the |
@yegor256 yes, |
@maxonfjvipon maybe let's do it this way (more compliant with the calculus):
|
@yegor256 this may work |
@abstract
attribute seems to redundant@abstract
attribute seems to be redundant
…attribute fix(#3529): remove abstract attribute
@rultor release, tag is |
We have a function
eo:abstract
and the@abstract
attribute. It seems that the attribute is redundant: we can get rid of it and only live with the function.The text was updated successfully, but these errors were encountered: