feat: add visionOS support #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @thiagobrez ! Great, thanks for the contribution! Sounds good to me, I've checked with an iOS engineer 👍 Could you add some docs? 🙏 |
|
@androideveloper Awesome! Just pushed a commit mentioning visionOS in the docs + 1 missing type for |
|
thanks! @oblador could you check this as well before I merge? 🙏 |
androideveloper
approved these changes
Feb 22, 2024
oblador
approved these changes
Feb 22, 2024
4 tasks
4 tasks
|
@thiagobrez could you please check this one? |
|
@androideveloper Sure, I was following the same approach on that code block but Sent a fix here: #631 |
SamuelScheit
pushed a commit
to respondchat/react-native-keychain
that referenced
this pull request
Jun 23, 2024
* feat: add visionOS support * docs: add visionOS docs
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Sep 6, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-keychain](https://redirect.github.com/oblador/react-native-keychain) | [`^8.1.3` -> `^8.2.0`](https://renovatebot.com/diffs/npm/react-native-keychain/8.1.3/8.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oblador/react-native-keychain (react-native-keychain)</summary> ### [`v8.2.0`](https://redirect.github.com/oblador/react-native-keychain/releases/tag/v8.2.0): 8.2.0 [Compare Source](https://redirect.github.com/oblador/react-native-keychain/compare/v8.1.3...v8.2.0) #### What's Changed - feat: add visionOS support by [@​thiagobrez](https://redirect.github.com/thiagobrez) in [https://github.com/oblador/react-native-keychain/pull/622](https://redirect.github.com/oblador/react-native-keychain/pull/622) #### New Contributors - [@​thiagobrez](https://redirect.github.com/thiagobrez) made their first contribution in [https://github.com/oblador/react-native-keychain/pull/622](https://redirect.github.com/oblador/react-native-keychain/pull/622) **Full Changelog**: oblador/react-native-keychain@v8.1.3...v8.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jean Regisser <[email protected]> Co-authored-by: valora-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for React Native visionOS, the new out-of-tree platform.
Vision OS has the new Optic ID biometric, but it behaves same as on iOS. All APIs used here are supported, so it was just a matter of considering
TARGET_OS_VISIONin the same preprocessor directives that already hadTARGET_OS_IOS.If you think this is good, I can update the docs with visionOS support in a next commit :)