Migrate usages of @react-native-community/art to react-native-svg #229
Conversation
|
Tested with Example app: screen-20210627-135912_Trim.mp4 |
# Conflicts: # Example/package.json # Example/yarn.lock
There was a problem hiding this comment.
Thanks a bunch for this, I know many have been looking forward to this PR. I've updated the Example app, fixed some minor lockfile misses so that it works with latest version of Xcode etc.
Overall it looks good to me, one minor regression however is that the progress circle in your PR is different from master behavior. Should be an easy fix, see the expected animation in the video below:
master.example.mp4
|
@oblador Found the issue. It seems that passing in a rotation transform to the Svg component in Circle.js when it's no longer rotating causes it to be flipped. I'm not exactly sure why this is the case, but found a workaround to pass in an undefined style when there is no rotation and this seems to have fixed it. screen-20210701-010820.mp4 |
|
CC @marlenecota - any concerns about functionality in svg that this PR depends on, re: the Windows support you're adding, or should we be good? |
| @@ -8,13 +8,13 @@ Progress indicators and spinners for React Native using ReactART. | |||
|
|
|||
| `$ npm install react-native-progress --save` | |||
|
|
|||
| ### ReactART based components | |||
| ### React Native SVG based components | |||
There was a problem hiding this comment.
There is still a reference to ReactART above ☝️ on line 3 https://github.com/oblador/react-native-progress/pull/229/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R3
More importantly: thank you for proposing this PR!
|
@oblador Could you take a quick look at this? |
|
Released in 5.0.0 |
|
Likewise @oblador thanks for your work here and on react-native-vector-icons, I use both in my projects to great effect, I really appreciate it. Cheres |
@react-native-community/art could be deprecated soon: react-native-art/art#75
This pull requests replaces usages of @react-native-community/art with the well-supported react-native-svg library.
This should also resolve #183