Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing black color fill for react-native-web and showing text percentage of filled circle. #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RaghavSekhri
Copy link

@RaghavSekhri RaghavSekhri commented Jan 6, 2022

This fill={fill} will change the color inside the circle for react-native-web and we need to pass fill='#00000000' from the frontend. This text change will show the correct percentage of the filled circle.

@@ -203,7 +204,7 @@ export class ProgressCircle extends Component {
]}
allowFontScaling={allowFontScaling}
>
{formatText(progressValue)}
{progress ? formatText(progress._value) : this.forceUpdate()}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Calling this.forceUpdate() from the render function might cause an infinite loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants