add: unfilledEndAngle prop to Circle.js #243
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking to use Progress.Circle as a semi-circle loader, however it seemed that the unfilled portion of the Circle.js component is always a constant of
const CIRCLE = Math.PI * 2
. I thought I'd contribute a new prop that allows users to dynamically set the end angle of the unfilled portion of the circle with theunfilledEndAngle
prop. This would allow users to make a semi-circle that's unfilled.It's written basically the same exact way as the
endAngle
prop.This also makes sure no shapes are shown if
unfilledEndAngle
is less than or equal to the currentstartAngle
of the<Shape />
component inside Circle.js. (Can be checked by turning thecolor
prop torgba(0,0,0,0)
)