add: alwaysUseEndAngle prop to Circle.js #245
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in Circle.js that
endAngle
is only used whenindeterminate
istrue
. I figured there is a reason for this, so I decided to add another prop calledalwaysUseEndAngle
. Which enablesendAngle
whether the loader is indeterminate or not.Also, I'm not sure if you'd like this added to the README or not, I'm assuming you do and I did so in this PR, but you never know! so let me know