-
Notifications
You must be signed in to change notification settings - Fork 47
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make http extension futures Send (#130)
#### Why are we making this change? I just tested out the new SurfExt trait with some of my production code. I was having trouble getting it working, as the futures it returns were not Send. This was mostly because `SerializeError` was not `Send + Sync`. #### What effects does this change have? This adds `Send + Sync` constraints to `SerializeError` which allows the futures in `SurfExt` & `ReqwestExt` to be `Send`. Possible that the API could have been reworked to do this without updating the constraints on `SerializeError`, but I'm fairly sure having errors as Send + Sync is good practice anyway.
- Loading branch information
Showing
3 changed files
with
4 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters