Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft attempt at some Q2Q causal relations. #351

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dosumis
Copy link
Contributor

@dosumis dosumis commented Feb 14, 2020

See See #350
DON'T MERGE YET! More discussion needed.

@dosumis dosumis changed the title First draft attempt at some Q2Q causal relations. See #350 First draft attempt at some Q2Q causal relations. Feb 14, 2020
@dosumis
Copy link
Contributor Author

dosumis commented Feb 14, 2020

Currently going with phenotype_results_in and phenotype_results_from, maybe simplify to phenotype results_from / results_in ?

There is demand for weaker sounding relations, do we add these?

Some examples (hemolytic anemia) might better be considered P->Q not Q->Q

For use within a phenotype def, should we restrict direction to results_from?

Ultimate aim is to define with reference to process -> process causal relations if poss but this will take work.

@matentzn
Copy link
Contributor

Does the label "phenotype" capture the wild type (i.e. normal phenotypes) as well? If so, I think I am good with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants