Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTR: 'is contact information for' #778

Closed
wants to merge 5 commits into from

Conversation

jmwhorton
Copy link
Contributor

Addresses issue #713

@jmwhorton jmwhorton changed the title NTR 'is contact information for' NTR: 'is contact information for' Dec 29, 2023
src/ontology/ro-edit.owl Outdated Show resolved Hide resolved
wdduncan
wdduncan previously approved these changes Jan 16, 2024
@anitacaron anitacaron linked an issue Feb 23, 2024 that may be closed by this pull request
@wdduncan
Copy link
Collaborator

is contact information is a subproperty of is about. However, is about is not included in RO.

There was consensus in #653 to add is about, but to give it an RO id. @mbrochhausen would a different cause issues for you? I am concerned about having a different IRI for such a widely used relation.

cc @cmungall @balhoff @bpeters42 @jamesaoverton @nataled @addiehl @matentzn

@mbrochhausen
Copy link

mbrochhausen commented Mar 27, 2024 via email

Copy link
Contributor

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

@github-actions github-actions bot added the stale label Jun 26, 2024
@mbrochhausen
Copy link

Hi,

can someone in the RO community please let me know, what I can or need to do to move this forward. Thx

@github-actions github-actions bot removed the stale label Jun 27, 2024
Copy link
Contributor

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

@github-actions github-actions bot added the stale label Oct 14, 2024
@jmwhorton
Copy link
Contributor Author

What needs to be done on this PR? The last update was from @mbrochhausen in June, asking what is needed to move this forward.

@wdduncan or @anitacaron Could you please let us know what we can do?

Thank you.

@wdduncan
Copy link
Collaborator

I believe got stalled over whether to make it a subproperty if is about (above). To move forward, I suggest we add the term without adding is about to RO.

@jmwhorton
Copy link
Contributor Author

@wdduncan Please correct me if I'm mistaken. That would mean we don't have to change the pull request, correct? (Apologies, I haven't looked at this in quite a while.)

@wdduncan
Copy link
Collaborator

@jmwhorton I don't know ... I haven't looked at the PR in a long time too :)

@jmwhorton
Copy link
Contributor Author

That is fair! The relevant detail is that the new term is listed as a sub object property of IAO 'is about'. Can that be left in?

SubObjectPropertyOf(obo:RO_0017007 obo:IAO_0000136)

@github-actions github-actions bot removed the stale label Oct 15, 2024
@cmungall
Copy link
Contributor

cmungall commented Oct 21, 2024 via email

@mbrochhausen
Copy link

I see Chris' point. I agree it might be better to submit it to IAO. We will happily do so, unless this generates an issue with OBO Foundry Principle 7 downstream. The way I read that principle, if a relation, such as 'is about' does not exist in RO, we can reuse that relations and its subproperties without being in violation of OBO Foundry principles. Is that correct?

@jmwhorton jmwhorton closed this Oct 28, 2024
@jmwhorton
Copy link
Contributor Author

Closing pull request. Term will possibly be submitted to IAO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTR: 'is contact information for'
6 participants