Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor azureeventhubrehydrationreceiver to stream blobs as to not lock up on larger environments (BPOP-831) #2098

Open
wants to merge 7 commits into
base: release/v1.69.0
Choose a base branch
from
Open

fix: refactor azureeventhubrehydrationreceiver to stream blobs as to not lock up on larger environments (BPOP-831) #2098

wants to merge 7 commits into from

Conversation

schmikei
Copy link
Contributor

@schmikei schmikei commented Jan 7, 2025

Proposed Change

  • Streaming results of the blobs rather than doing a lump sum for the requests of the blobs. This would cause the collector to stall for large rehydration efforts using azure eventhub.
Checklist
  • Changes are tested
  • CI has passed

@schmikei schmikei changed the title pre tests working; refactor to stream blobs as to not lock up fix: refactor azureeventhubrehydrationreceiver to stream blobs as to not lock up on larger environments (BPOP-831) Jan 7, 2025
@schmikei schmikei marked this pull request as ready for review January 9, 2025 21:41
@schmikei schmikei requested review from dpaasman00 and a team as code owners January 9, 2025 21:41
@schmikei
Copy link
Contributor Author

schmikei commented Jan 9, 2025

Opening up for review; but going to see if I can add some more tests/benchmarks as I go before merging anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpaasman00 dpaasman00 Awaiting requested review from dpaasman00 dpaasman00 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schmikei