Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused libraries #13

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Remove unused libraries #13

merged 3 commits into from
Oct 16, 2023

Conversation

jonathan-waarneming-nl
Copy link
Collaborator

@jonathan-waarneming-nl jonathan-waarneming-nl commented Oct 11, 2023 •
edited
Loading

Remove moment, i18n-iso-countries, i18n-js and react-native-localize from the repo.

Part of: https://github.com/observation/app/issues/86

SjaakSchilperoort
SjaakSchilperoort approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@SjaakSchilperoort SjaakSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Heb je nog gecheckt of er nog meer ongebruikte packages zijn?

@jonathan-waarneming-nl
Copy link
Collaborator Author

jonathan-waarneming-nl commented Oct 12, 2023 •
edited
Loading

@SjaakSchilperoort
Er zijn nog 3 packages die ook weg. Die zaten er oorspronkelijk in, toen i18n er nog in zat:

  • i18n-iso-countries
  • i18n-js
  • react-native-localize

Zal ik die meenemen?

@jonathan-waarneming-nl jonathan-waarneming-nl changed the title Remove moment Remove unused libraries Oct 16, 2023
@jonathan-waarneming-nl jonathan-waarneming-nl merged commit b430184 into develop Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SjaakSchilperoort SjaakSchilperoort SjaakSchilperoort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathan-waarneming-nl @SjaakSchilperoort