Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed react-native-image-viewing #42

Merged
merged 2 commits into from
May 8, 2024

Conversation

SjaakSchilperoort
Copy link
Member

@SjaakSchilperoort SjaakSchilperoort commented May 7, 2024

Include a version of react-native-image-viewing that supports use in React Native 0.74.

Verified that the change works for both Observation @ RN 0.73 and ObsIdentify @ RN 0.74.

Also, configured .nvmrc to use the font awesome authentication token from an environment variable, and configured CI to set this environment variable from a repository secret. For a local development environment, this token should be setup in the environment of the shell, e.g. ~/.profile.

Copy link
Collaborator

@jonathan-waarneming-nl jonathan-waarneming-nl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wel een fijne config change zo

@SjaakSchilperoort SjaakSchilperoort merged commit 56a35fb into develop May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants