-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rotate icon and crop button in Lightbox #48
Conversation
73de7dc
to
a8ec725
Compare
@SjaakSchilperoort Zou je hier naar willen kijken? |
src/lib/Icons.ts
Outdated
@@ -241,6 +243,7 @@ type IconName = Extract< | |||
| 'images' | |||
| 'info-circle' | |||
| 'language' | |||
| 'level-down' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De naam in Font Awesome is arrow-turn-down
. Waarom gebruik je die naam niet?
Ik zie dat Karel in het design arrow-turn-down
90 graden naar links draait, maar je kunt dan toch net zo goed arrow-turn-right
gebruiken? Dan hebben we (nog) geen support voor rotatie nodig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idd. Ik wist niet dat die ook bestond. Zal dat doen.
@@ -42,6 +42,7 @@ const getLightboxFooterComponent = | |||
content?: React.ReactNode, | |||
style?: LightboxStyle, | |||
onPressDelete?: () => void, | |||
onPressCrop?: () => void, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests hiervoor ontbreken nog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idd, zal ze toevoegen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Part of: https://github.com/observation/app/issues/287