Add rotate icon and crop button in Lightbox #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-waarneming-nl
force-pushed
the
feature/crop-icons
branch
from
73de7dc
to
a8ec725
Compare
jonathan-waarneming-nl
changed the title
|
@SjaakSchilperoort Zou je hier naar willen kijken? |
src/lib/Icons.ts
Outdated
| @@ -241,6 +243,7 @@ type IconName = Extract< | |||
| | 'images' | |||
| | 'info-circle' | |||
| | 'language' | |||
| | 'level-down' | |||
There was a problem hiding this comment.
De naam in Font Awesome is arrow-turn-down. Waarom gebruik je die naam niet?
Ik zie dat Karel in het design arrow-turn-down 90 graden naar links draait, maar je kunt dan toch net zo goed arrow-turn-right gebruiken? Dan hebben we (nog) geen support voor rotatie nodig.
There was a problem hiding this comment.
Idd. Ik wist niet dat die ook bestond. Zal dat doen.
| @@ -42,6 +42,7 @@ const getLightboxFooterComponent = | |||
| content?: React.ReactNode, | |||
| style?: LightboxStyle, | |||
| onPressDelete?: () => void, | |||
| onPressCrop?: () => void, | |||
There was a problem hiding this comment.
Unit tests hiervoor ontbreken nog
There was a problem hiding this comment.
Idd, zal ze toevoegen
added 2 commits
July 1, 2024 20:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/observation/app/issues/287