Upgrade eslint #52
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| import path from 'node:path' | ||
| import { fileURLToPath } from 'node:url' | ||
|
|
||
| import { fixupPluginRules } from '@eslint/compat' | ||
| import { FlatCompat } from '@eslint/eslintrc' | ||
| import js from '@eslint/js' | ||
| import tsParser from '@typescript-eslint/parser' | ||
| import _import from 'eslint-plugin-import' | ||
| import jsxA11Y from 'eslint-plugin-jsx-a11y' | ||
| import observation from 'eslint-plugin-observation' | ||
| import prettier from 'eslint-plugin-prettier' | ||
| import react from 'eslint-plugin-react' | ||
| import reactNative from 'eslint-plugin-react-native' | ||
| import globals from 'globals' | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url) | ||
| const __dirname = path.dirname(__filename) | ||
| const compat = new FlatCompat({ | ||
| baseDirectory: __dirname, | ||
| recommendedConfig: js.configs.recommended, | ||
| allConfig: js.configs.all, | ||
| }) | ||
|
|
||
| export default [ | ||
| ...compat.extends('plugin:@typescript-eslint/recommended'), | ||
| { | ||
| plugins: { | ||
| 'react-native': fixupPluginRules(reactNative), | ||
| react, | ||
| 'jsx-a11y': jsxA11Y, | ||
| import: fixupPluginRules(_import), | ||
| prettier, | ||
| observation, | ||
| }, | ||
|
|
||
| languageOptions: { | ||
| globals: { | ||
| ...globals.jest, | ||
| ...globals.browser, | ||
| }, | ||
|
|
||
| parser: tsParser, | ||
| }, | ||
|
|
||
| settings: { | ||
| 'import/resolver': { | ||
| node: { | ||
| paths: ['.'], | ||
| extensions: ['.js', '.jsx', '.android.js', '.ios.js', '.native.js', '.ts', '.tsx'], | ||
| }, | ||
| }, | ||
| }, | ||
|
|
||
| rules: { | ||
| 'observation/no-function-without-logging': 'error', | ||
|
|
||
| 'react-native/no-unused-styles': 'error', | ||
| 'react-native/no-inline-styles': 'off', | ||
|
|
||
| 'prettier/prettier': 'error', | ||
|
|
||
| 'no-shadow': 'off', | ||
| semi: ['error', 'never'], | ||
| 'no-console': 'warn', | ||
| curly: ['error', 'multi-line'], | ||
| 'prefer-destructuring': ['error'], | ||
| 'no-duplicate-imports': 'error', | ||
|
|
||
| 'sort-imports': [ | ||
| 'error', | ||
| { | ||
| ignoreDeclarationSort: true, | ||
| }, | ||
| ], | ||
|
|
||
| '@typescript-eslint/no-shadow': ['error'], | ||
| '@typescript-eslint/no-explicit-any': 'off', | ||
| '@typescript-eslint/no-var-requires': 'off', | ||
| '@typescript-eslint/no-unused-vars': [ | ||
| 'error', | ||
| { | ||
| args: 'all', | ||
| argsIgnorePattern: '^_', | ||
| caughtErrors: 'all', | ||
| caughtErrorsIgnorePattern: '^_', | ||
| destructuredArrayIgnorePattern: '^_', | ||
| varsIgnorePattern: '^_', | ||
| ignoreRestSiblings: true, | ||
| }, | ||
| ], | ||
|
|
||
| 'import/order': [ | ||
| 'error', | ||
| { | ||
| groups: ['builtin', 'external', 'internal', ['parent', 'sibling']], | ||
|
|
||
| pathGroups: [ | ||
| { | ||
| pattern: 'react+(|-native)', | ||
| group: 'external', | ||
| position: 'before', | ||
| }, | ||
| ], | ||
|
|
||
| pathGroupsExcludedImportTypes: ['react+(|-native)'], | ||
| 'newlines-between': 'always', | ||
|
|
||
| alphabetize: { | ||
| order: 'asc', | ||
| caseInsensitive: true, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| { | ||
| files: ['**/*.ts', '**/*.tsx'], | ||
|
|
||
| rules: { | ||
| 'no-undef': 'off', | ||
| }, | ||
| }, | ||
| { | ||
| files: ['**/*test.ts', '**/*test.tsx'], | ||
|
|
||
| rules: { | ||
| 'observation/no-function-without-logging': 'off', | ||
| }, | ||
| }, | ||
| ] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eerst extenden we van
@react-nativenu deze. Waarom?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Voor zover ik het begrijp: extends bestaat niet meer sinds eslint 8.0.0. In plaats daarvan bestaat de configuratie uit een array van configuratie-objecten. Er is een utility
FileCompatom hieraan eslint-configuraties toe te voegen die nog geen flat eslint-configuration hebben. De helperfixupPluginRulesvoor plugins doet iets dergelijks, is meer low level, en wordt intern doorFileCompatgebruikt.De configuratie in deze PR werkt voor de eslint packages die wij gebruiken. Als alle eslint packages support voor eslint 8.0.0 hebben gekregen, dan hebben we
FlatCompatenfixupPluginRulesniet meer nodig.